Attention is currently required from: Julius Werner, Jérémy Compostella, Nico Huber, Philipp Hug, Ron Minnich.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83574?usp=email )
Change subject: Makefile.mk: Add a common link_stage function and use it
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83574/comment/f4f45fa8_17137a5b?usp... :
PS2, Line 16: - the x86 --oformat is dropped as it is not needed.
Would be nice to do this in smaller steps, e.g. one patch to drop --oformat,
one to drop LIBGCC_FILE_NAME_ (this one looks like a merge artifact after
switching to COMPILER_RT_ in November 2014 oO).
And now I just realized why we don't need the `--oformat`. It's because we
use separate toolchains now? i.e. the x86_64 one doesn't support i386 any
more. But wouldn't this break compiling with a host toolchain?
I think defining the format in the linker script would be a clean solution to that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83574?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64f7686894c99732d06972e7ba327061db6d7c44
Gerrit-Change-Number: 83574
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 19 Jul 2024 11:58:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de