Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32083 )
Change subject: payload/libpayload: This is a fix for potential NULL pointer dereferences
......................................................................
Patch Set 7:
(1 comment)
Oh, wait, Jenkins actually thinks it doesn't look good. But after you fix that typo it looks good to me.
https://review.coreboot.org/#/c/32083/7/payloads/libpayload/drivers/usb/ohci...
File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/#/c/32083/7/payloads/libpayload/drivers/usb/ohci...
PS7, Line 690: final_td
This must be 'intrq'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32083
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d4636f0429de829e746909492c2f543026a02ac
Gerrit-Change-Number: 32083
Gerrit-PatchSet: 7
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 27 Mar 2019 23:48:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment