David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45111 )
Change subject: mb/google/volteer/var/voxel: Update DPTF parameters and TCC offset ......................................................................
Patch Set 4:
(3 comments)
Thanks
https://review.coreboot.org/c/coreboot/+/45111/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voxel/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45111/3/src/mainboard/google/voltee... PS3, Line 17: # Default DPTF Policy for all Volteer boards if not overridden
not true here 😊
Done
https://review.coreboot.org/c/coreboot/+/45111/3/src/mainboard/google/voltee... PS3, Line 83: ## Charger Performance Control (Control, mA) : register "controls.charger_perf[0]" = "{ 255, 1700 }" : register "controls.charger_perf[1]" = "{ 24, 1500 }" : register "controls.charger_perf[2]" = "{ 16, 1000 }" : register "controls.charger_perf[3]" = "{ 8, 500 }" : : ## Fan Performance Control (Percent, Speed, Noise, Power) : register "controls.fan_perf[0]" = "{ 90, 6700, 220, 2200, }" : register "controls.fan_perf[1]" = "{ 80, 5800, 180, 1800, }" : register "controls.fan_perf[2]" = "{ 70, 5000, 145, 1450, }" : register "controls.fan_perf[3]" = "{ 60, 4900, 115, 1150, }" : register "controls.fan_perf[4]" = "{ 50, 3838, 90, 900, }" : register "controls.fan_perf[5]" = "{ 40, 2904, 55, 550, }" : register "controls.fan_perf[6]" = "{ 30, 2337, 30, 300, }" : register "controls.fan_perf[7]" = "{ 20, 1608, 15, 150, }" : register "controls.fan_perf[8]" = "{ 10, 800, 10, 100, }" : register "controls.fan_perf[9]" = "{ 0, 0, 0, 50, }"
identical to what is already in the baseboard tree, not required here.
Done
https://review.coreboot.org/c/coreboot/+/45111/3/src/mainboard/google/voltee... PS3, Line 101: # Fan options : register "options.fan.fine_grained_control" = "1" : register "options.fan.step_size" = "2"
identical to what is already in the baseboard tree, not required here.
Done