[coreboot-gerrit] Change in ...coreboot[master]: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by ...

[mikeb mikeb (Code Review)]

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31357 )

Change subject: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31357/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31357/2//COMMIT_MSG@11 
PS2, Line 11:
> For size reasons? What is the difference?

bios.bin.elf with these three features: 128960 bytes, without them: 109600 bytes.
128960 - 109600 = 19360 bytes, about 19KB difference, seems pretty good.

Another nice benefit is a cleaner build: G505S could never have this hardware,
so these options should be disabled just like the Generic Drivers options
for SIL3114 and TPS65913 chips are disabled by default for this board