View Change
1 comment:
Commit Message:
Patch Set #2, Line 11:
For size reasons? What is the difference?
bios.bin.elf with these three features: 128960 bytes, without them: 109600 bytes.
128960 - 109600 = 19360 bytes, about 19KB difference, seems pretty good.
Another nice benefit is a cleaner build: G505S could never have this hardware,
so these options should be disabled just like the Generic Drivers options
for SIL3114 and TPS65913 chips are disabled by default for this board
To view, visit change 31357. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b2ee6403d7d2298725729d8d833e37627a4f202
Gerrit-Change-Number: 31357
Gerrit-PatchSet: 2
Gerrit-Owner: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 12 Feb 2019 20:36:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment