Attention is currently required from: Ian Feng, Pranava Y N.
Subrata Banik has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/85116?usp=email )
Change subject: mb/google/fatcat/var/francka: Add overridetree
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/fatcat/variants/francka/fw_config.c:
https://review.coreboot.org/c/coreboot/+/85116/comment/8821ff48_e38c0431?usp... :
PS3, Line 29:
You wish to add a comment to say what these pins does??
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85116?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a50ca095922cdd67c3f2b13e4727608c3644d86
Gerrit-Change-Number: 85116
Gerrit-PatchSet: 3
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 13 Nov 2024 09:52:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes