Attention is currently required from: Arthur Heymans, Nico Huber, Patrick Rudolph, Angel Pons, Julius Werner, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin. Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )
Change subject: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build time ......................................................................
Patch Set 30:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51671/comment/dc05e331_3443784f PS29, Line 22: Test passed on Elitebook Folio 9470m.
Um, what exactly has been tested? This board doesn't use EC firmware pointers (its Kconfig disables […]
EC_HP_KBC1126_ECFW_IN_CBFS is disabled in folio_9480m's Kconfig. folio_9470m is a variant of snb_ivb_laptops, in which EC_HP_KBC1126_ECFW_IN_CBFS is left enabled.
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/51671/comment/db5d7db3_acfc6315 PS29, Line 357: config ECFW_PTR_SIZE : int : help : Size of reserved space for EC firmware pointer
This is completely unused
Now it is used in ecfw_ptr.c as a static assert.
File src/ec/hp/kbc1126/Kconfig:
https://review.coreboot.org/c/coreboot/+/51671/comment/e12411d7_4af52844 PS29, Line 30: if EC_HP_KBC1126
This guard is redundant, because `EC_HP_KBC1126_ECFW_IN_CBFS` already depends on `EC_HP_KBC1126`. […]
Done
File src/ec/hp/kbc1126/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51671/comment/7bb77623_21e91e05 PS29, Line 4: KBC1126_EC_INSERT:=$(top)/util/kbc1126/kbc1126_ec_insert
No longer needed, please drop
Done
https://review.coreboot.org/c/coreboot/+/51671/comment/8aea17df_53c57980 PS29, Line 7: bootblock-y += ecfw_ptr.c
This should always be compiled in when `EC_HP_KBC1126_ECFW_IN_CBFS` is true, not only when `EC_HP_KB […]
Done