Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Deepti Deshatty, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54089 )
Change subject: soc/intel/alderlake: mb/intel/sm: Add tcss code
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/54089/comment/c3d74251_626651a0
PS2, Line 133: params->IomTypeCPortPadCfg[i] = config->IomTypeCPortPadCfg[i];
If you didn't set it, default is 0, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifce6abb0fce20e408931b904426131a42a5a4a36
Gerrit-Change-Number: 54089
Gerrit-PatchSet: 2
Gerrit-Owner: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 17 May 2021 11:12:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment