Hello Varshit B Pandya, build bot (Jenkins), Furquan Shaikh, Subrata Banik, Aamir Bohra, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39498
to look at the new patch set (#3).
Change subject: src/soc/intel/tigerlake: Fix incorrect use of Field objects in ASL ......................................................................
src/soc/intel/tigerlake: Fix incorrect use of Field objects in ASL
Method RAOW is assuming that the first argument is a Field object and writing to it expecting the register to get updated. However, the callers are passing in the value of the Field object instead.
This eventually is resulting the IMGCLK not getting enable/disabled on the platform.
Fix this by sending the exact address of the register to be updated.
BUG=None BRANCH=None TEST=Build and Boot waddledoo board and verified that IMGCLKOUT for world facing camera is enabled/disabled and able to capture images.
Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Change-Id: I8b886255d5f38819502ae1f4af0851b5a0922b22 --- M src/soc/intel/tigerlake/acpi/camera_clock_ctl.asl 1 file changed, 19 insertions(+), 70 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/39498/3