Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35555 )
Change subject: mediatek/mt8183: Save multiple frequency calibration result to shuffle ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/emi... PS3, Line 375: #if CONFIG(MT8183_DRAM_DUAL_FREQ_K) don't need this #if
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/emi... PS3, Line 488: #if (CONFIG(MT8183_DRAM_DUAL_FREQ_K)) : freq_shuffle = DRAM_DFS_SHUFFLE_3; : #endif change to
if (CONFIG(MT8183_DRAM_DUAL_FREQ_K)) ...
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/emi... PS3, Line 498: #if (CONFIG(MT8183_DRAM_DUAL_FREQ_K)) if (CONFIG(...)) { }