[coreboot-gerrit] Change in coreboot[master]: vc/amd/cimx/sb800: Remove old strict-aliasing workaround

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34783 )

Change subject: vc/amd/cimx/sb800: Remove old strict-aliasing workaround
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34783/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34783/1//COMMIT_MSG@35 
PS1, Line 35: ReadMEM() and WriteMEM() now match their definitions in the SB900 code.
> So older GCC gave an error?

I'm not sure. GCC does have -Wstrict-aliasing to try to warn about these sort of things, but that shouldn't have been a problem since these functions are compiled separately from where they are called (so GCC would have no way of knowing if they actually alias or not). The code was like this when it was checked into coreboot, so it was probably a workaround for some AMD issue back in ye olden days.