11 May
2020
11 May
'20
2:19 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41224 )
Change subject: mb/asus/.../p3b-f: Enable flashrom in ramstage final ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41224/1/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p3b-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41224/1/src/mainboard/asus/p2b/vari... PS1, Line 22: if (r < 0) Is it needed to split the strings like that? I would use full statements instead, so that the error message can use BIOS_ERR or BIOS_NOTICE instead of BIOS_INFO
--
To view, visit https://review.coreboot.org/c/coreboot/+/41224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I684f8f560a714cbcaf56033202a841e6801ad999
Gerrit-Change-Number: 41224
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 May 2020 08:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment