Joe Tessler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48523 )
Change subject: hatch: enable genesis PCIe/USB devices ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48523/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/genesis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48523/1/src/mainboard/google/hatch/... PS1, Line 56: .ocpin = OC0, : .tx_bias = USB2_BIAS_0MV, : .tx_emp_enable = USB2_PRE_EMP_ON, : .pre_emp_bias = USB2_BIAS_28P15MV, : .pre_emp_bit = USB2_HALF_BIT_PRE_EMP,
Does this actually help?
No, it did not change anything. We discovered some HW problems with that component, so it remains untested. Do you suggest reverting this?