[coreboot-gerrit] Change in coreboot[master]: cpu/intel/model_fxx: Select SSE2

[Arthur Heymans (Code Review)]

Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64666 )

Change subject: cpu/intel/model_fxx: Select SSE2
......................................................................

Patch Set 1:

(1 comment)

File src/cpu/intel/model_f2x/Kconfig:

https://review.coreboot.org/c/coreboot/+/64666/comment/309795ae_4a48f2ae 
PS1, Line 7: 	select SSE2
> Hmm.. the SSE2 default below is no longer honoured, but I think we can just remove it. My aopen/dxplplusu is the only that could break. And the comment may actually originate from romcc romstage times from around 2011.
>
> if CPU_INTEL_SOCKET_MPGA604
>    select CPU_INTEL_MODEL_F2X
> ,,,
>    select SSE
>
> # mPGA604 are usually Intel Netburst CPUs which should have SSE2
> # but the ramtest.c code on the Dell S1850 seems to choke on
> # enabling it, so disable it for now.
> config SSE2
>    bool
>    default n

Let's keep it then. The pre-SSE2 mfence should also work.