Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44185 )
Change subject: drivers/usb: Avoid value overwritten before its usage ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44185/1/src/drivers/usb/ehci_debug.... File src/drivers/usb/ehci_debug.c:
https://review.coreboot.org/c/coreboot/+/44185/1/src/drivers/usb/ehci_debug.... PS1, Line 603: return -10; I'd put `return ret;` here instead, to not alter the behavior of the code. I suspect the return statement was commented-out for some reason