陳祥睿 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45246 )
Change subject: mb/google/volteer/variants/eldrid: Configure DP_HPD as PAD_NC
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45246/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45246/3//COMMIT_MSG@7
PS3, Line 7:
extra space
done
https://review.coreboot.org/c/coreboot/+/45246/3//COMMIT_MSG@8
PS3, Line 8: and disable DdiPortHpd
You mention this below, the line above is a good summary, I'd remove this.
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31b25be1c9248debf855435c7b688b358e2cd57e
Gerrit-Change-Number: 45246
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: 陳祥睿
n24211096@gmail.com
Gerrit-Comment-Date: Thu, 17 Sep 2020 01:27:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment