Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46126 )
Change subject: mb/google/puff/var/dooly: Update devicetree for project change
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46126/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46126/3//COMMIT_MSG@9
PS3, Line 9: 1. Update USB configuration
: USBA*2
: USBC*2
:
: 2. Remove unused device
: no SD card reader
: no built-in LAN
:
: 3. Add audio configuration
: ALC1015 speaker amplifier
:
: 4. Enable dmic+ssp registers
: DMIC for camera module
:
this is a bit easier to review if you split this into three commits, one for (2), then (1), then (3 & 4).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb66a8d5382ca9664e7f0b3660f446aeb3cf1dd3
Gerrit-Change-Number: 46126
Gerrit-PatchSet: 3
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 09 Oct 2020 04:03:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment