Attention is currently required from: Hung-Te Lin, Martin Roth, Rex-BC Chen, Yu-Ping Wu, JG Poxu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52598 )
Change subject: soc/mediatek/mt8195: Add GPIO driver
......................................................................
Patch Set 5:
(3 comments)
File src/soc/mediatek/mt8195/gpio.c:
https://review.coreboot.org/c/coreboot/+/52598/comment/50a705c9_e731bcd8
PS4, Line 5: #include <assert.h>
Do we need this?
Done
https://review.coreboot.org/c/coreboot/+/52598/comment/ee641923_bd7a8ffa
PS4, Line 54: )
Add {} for if clause
Done
File src/soc/mediatek/mt8195/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/52598/comment/8ff1576b_17118257
PS4, Line 42: TP_GPIO0_AO
Please align with "0"
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica1b1c80a851075599442298bb6675caf5c72f57
Gerrit-Change-Number: 52598
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: JG Poxu
jg_poxu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: JG Poxu
jg_poxu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 09:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment