Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37283 )
Change subject: soc/intel/common/block/cse: Modify handling of HMRFPO_ENABLE command
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37283/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37283/5//COMMIT_MSG@21
PS5, Line 21: opmode Temp Disable Mode.
I still have not seen any documentation from Intel about this. It
doesn't seem to reflect how it usually works. Please don't mix
information about specific firmware versions with the generic
`cse.c`, unless all future firmware versions work like this. Then,
maybe we should give this some versioning? new/old CSE?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37283
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c87998fa105947e5ba4638a8e68625e46703448
Gerrit-Change-Number: 37283
Gerrit-PatchSet: 5
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Mon, 23 Dec 2019 15:29:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment