Ben Chuang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45062 )
Change subject: drivers/genesyslogic/gl9755: Add driver for Genesys Logic GL9755
......................................................................
Patch Set 6:
(1 comment)
Patch Set 6: Code-Review+2
I think INFO is fine, loglevel.h says about INFO: "Log level for when the system has experienced some typical event. Messages should be superficial in nature"
Thanks for your comments.
https://review.coreboot.org/c/coreboot/+/45062/5/src/drivers/genesyslogic/gl...
File src/drivers/genesyslogic/gl9755/gl9755.c:
https://review.coreboot.org/c/coreboot/+/45062/5/src/drivers/genesyslogic/gl...
PS5, Line 15: printk(BIOS_INFO, "GL9755: init\n");
Don't worry.
Well, I will keep the BIOS_INFO level. 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16048dde348be248c748d50ca4a8a62c8a781430
Gerrit-Change-Number: 45062
Gerrit-PatchSet: 6
Gerrit-Owner: Ben Chuang
benchuanggli@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alex Levin
levinale@google.com
Gerrit-CC: Greg Tu
greg.tu@genesyslogic.com.tw
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: HsuanYang Chen
ynop77@gmail.com
Gerrit-CC: Jerry Hu
jerry.huyc@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: 陳建宏
renius.chen@genesyslogic.com.tw
Gerrit-Comment-Date: Fri, 18 Sep 2020 03:48:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ben Chuang
benchuanggli@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment