Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46570 )
Change subject: mb/google/asurada: fix EC_IN_RW polarity
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46570/1/src/mainboard/google/asurad...
File src/mainboard/google/asurada/chromeos.c:
https://review.coreboot.org/c/coreboot/+/46570/1/src/mainboard/google/asurad...
PS1, Line 23: ACTIVE_LOW
Verified that gpio454 is 1 after normal boot. […]
got it, thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46570
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd5
Gerrit-Change-Number: 46570
Gerrit-PatchSet: 1
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 20 Oct 2020 09:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment