Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47234 )
Change subject: sb/intel/lynxpoint: Correct SATA DTLE IOBP registers
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47234/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47234/1//COMMIT_MSG@9
PS1, Line 9: Testing
Would be nice to elaborate on the testing. Could you break functionality […]
It's what has been described here: https://review.coreboot.org/c/coreboot/+/45578/8/src/mainboard/hp/folio_9480...
Essentially, not applying the IOBP settings for "port 0" made port 1 stop working. I don't have any Haswell ULT board nearby I could test things on, however.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie47c9fddc2e9e15ce4c64821ea3a69356ac31b1a
Gerrit-Change-Number: 47234
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Nov 2020 15:46:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment