Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43400 )
Change subject: util/cbfstool/fit.c: Add support for adding Boot Guard manifests
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43400/1/util/cbfstool/fit.c
File util/cbfstool/fit.c:
https://review.coreboot.org/c/coreboot/+/43400/1/util/cbfstool/fit.c@486
PS1, Line 486: fit_entry_update_size(entry, key_manifest_size << 4);
add new helper method
I am not sure it is worth, since simple bit shift works. At least please let me know how do you see the new helper method.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43400
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c33d3c1dd2267ae5e0bccb57b716135598ea197
Gerrit-Change-Number: 43400
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Jul 2020 09:32:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment