Attention is currently required from: Keith Hui, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78206?usp=email )
Change subject: nb/intel/sandybridge: Pre-render constants in MRC pei_data
......................................................................
Patch Set 4:
(1 comment)
File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/c/coreboot/+/78206/comment/fa2732ee_4f8df9e3 :
PS4, Line 404: struct pei_data pei_data;
This is a (pretty extreme) optimization attempt. […]
Considering that the behaviour of struct initialisers in this regard is defined by the C standard, I don't think comments should be needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78206?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0f429a7be11ea497ce31cde007966ea988a256f
Gerrit-Change-Number: 78206
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Sun, 14 Apr 2024 19:28:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment