[coreboot-gerrit] Change in coreboot[master]: arch/x86: Top align bootblock program

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37895 )

Change subject: arch/x86: Top align bootblock program
......................................................................

Patch Set 9:
> Patch Set 9:
> > Patch Set 9:
> >
> > Raul, a related bug (that I cannot access) b:154957411 on amd/picasso.
> >
> > https://review.coreboot.org/c/coreboot/+/37490/12/src/soc/amd/picasso/Makefi...
>
> We could always use readelf in the makefile instead of modifying amdfwtool.

I think approach of first creating single amdfw.rom with util/amdfwtool and then placing it with util/cbfstool is not that convenient. You need parts of amdfw.rom in RO and others in RW ?

Due the lack of public PSP (directory table) documentation of metadata/header I cannot really share much of my ideas here. Try to discuss internally if current separation of util/cbfstool/amdcompress and util/amdfwtool works well for you.