Attention is currently required from: Naveen M, Pranava Y N, Varun Upadhyay.
Paul Menzel has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/85440?usp=email )
Change subject: mb/google/fatcat: Update Soundwire codec address based on devicetree
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85440/comment/5fe5f24d_dd4753a8?usp... :
PS1, Line 8:
Please elaborate. Maybe:
Currently, Kconfig selects …, so that address is hard-coded. As the device can also have codec …, select … and configure the address in the devicetree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85440?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3322ae2d106d3628dbf627aacf999056d82ee7a9
Gerrit-Change-Number: 85440
Gerrit-PatchSet: 1
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Naveen M
naveen.m@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Naveen M
naveen.m@intel.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 02 Dec 2024 14:57:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No