Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39280 )
Change subject: soc/intel/tigerlake: Correct FSP log interface ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39280/11/src/soc/intel/tigerlake/ro... File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/39280/11/src/soc/intel/tigerlake/ro... PS11, Line 78: pcidev_path_on_root(PCH_DEVFN_TRACEHUB)
What about checking enabled?
Done
https://review.coreboot.org/c/coreboot/+/39280/15/src/soc/intel/tigerlake/ro... File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/39280/15/src/soc/intel/tigerlake/ro... PS15, Line 29: const struct device *tracehub = pcidev_path_on_root(PCH_DEVFN_TRACEHUB);
you can use the dev variable: […]
Done