Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34540 )
Change subject: src/mainboard: Add PCI device for IUO1 and IOU2 to devicetree ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/34540/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34540/1//COMMIT_MSG@9 PS1, Line 9: With commit 8950cfb66f8f1fd4b047fbef2347134be0aeacec : (soc/intel: Use config_of()) a new function was introduced to get the : pointer to the devicetree-config for a given device. Maybe:
Commit 8950cfb6 (soc/intel: Use config_of()) adds a new function to get the pointer to the devicetree config for a given device.
https://review.coreboot.org/c/coreboot/+/34540/1//COMMIT_MSG@17 PS1, Line 17: NULL-pointer I’d spell it without -.
https://review.coreboot.org/c/coreboot/+/34540/1//COMMIT_MSG@25 PS1, Line 25: derefferenced dereferenced