Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45943 )
Change subject: vc/amd/fsp: Update bl_errorcodes_public.h ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45943/2/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/fch.c:
https://review.coreboot.org/c/coreboot/+/45943/2/src/soc/amd/picasso/psp_ver... PS2, Line 127: (uint32_t)
I'm not seeing why these casts were necessary
Done
https://review.coreboot.org/c/coreboot/+/45943/2/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_errorcodes_public.h:
https://review.coreboot.org/c/coreboot/+/45943/2/src/vendorcode/amd/fsp/pica... PS2, Line 3: * Copyright (c) 2020, Advanced Micro Devices, Inc.
I'm kind of a meh on using 2019. This file first showed up in the coreboot source in 2020. […]
This came from AMD with the copyright 2020, so I left it. I honestly don't think it really matters, as the old copyright is in the git history, so if there were a question, we could go back to that. Also, my understanding is that there's no need to do 2019-2020, because the oldest copyright date applies. I don't know the various copyright laws around the world, but if this file is still in use when the copyright expires in the US, I'll be amazed.