Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37645 )
Change subject: mb/google/hatch: Add mushu variant
......................................................................
Patch Set 5:
(2 comments)
Looking at review comments for overridetree.cb.
This is a currently a direct copy of the hatch/puff version.
The hatch/mushu version may or may not change going forward.
https://review.coreboot.org/c/coreboot/+/37645/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37645/4//COMMIT_MSG@7
PS4, Line 7: mushu: Create initial build
mb/google/hatch: Add mushu variant
Done
https://review.coreboot.org/c/coreboot/+/37645/4//COMMIT_MSG@11
PS4, Line 11: >>
One `>` too much?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81b5bf960ead0463159ac35f4f96e3ccc8c0364e
Gerrit-Change-Number: 37645
Gerrit-PatchSet: 5
Gerrit-Owner: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matthew Blecker
matthewb@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Dec 2019 23:39:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment