Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54016 )
Change subject: mb/intel/adlrvp: Disable EC sync for adlrvp_ext_ec
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Surprisingly, platform doesn't go to recovery but I see below error: […]
Yeah, this is an attribute of the broken mocktpm behavior and the assumptions we have made in different places (in this case EFS).
The problem here is that `vb2_secdata_kernel_get_ec_hash()` in vboot_reference assumes that it is safe to store/read mirrored hash from TPM and compare it with the expected hash irrespective of whether EFS is being used or not. But, this doesn't really work in case of mocktpm.
Aseda recently ran into this on keeby as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62a4fceb83dc6b20f699b4662e8f421aadafdee5
Gerrit-Change-Number: 54016
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Wed, 12 May 2021 06:34:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment