20 Apr
2022
20 Apr
'22
5:43 a.m.
Attention is currently required from: V Sowmya, Paul Menzel, Arthur Heymans, Balaji Manigandan, Krishna P Bhat D. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62913 )
Change subject: mb/intel/adlrvp: Set half_populated true for ADL-N ......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62913/comment/0ba48c1c_682f54bd PS13, Line 58: !!(CONFIG(BOARD_INTEL_ADLRVP_N_EXT_EC) : || CONFIG(BOARD_INTEL_ADLRVP_N)
Is the same without !! ;-)
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/62913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecc3018a1ab039990ba47898ff0e0e2ede695cc
Gerrit-Change-Number: 62913
Gerrit-PatchSet: 14
Gerrit-Owner: Usha P usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: V Sowmya v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Kangheui Won khwon@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: V Sowmya v.sowmya@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-Attention: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Wed, 20 Apr 2022 05:43:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment