Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44157 )
Change subject: mb/google/zork: SW changes for HP_INT_ODL in schematic v3.6 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c:
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 97: PAD_GPI(GPIO_84), Just realized that this will have to be: PAD_GPI(GPIO_84, PULL_NONE)
i.e. PAD_GPI takes 2 arguments.
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 69: PAD_GPI(GPIO_29), Same here: PAD_GPI(GPIO_29, PULL_NONE),