Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44294 )
Change subject: drivers/amd/agesa: Don't save regular boot MTRR to flash
......................................................................
Patch Set 5:
(1 comment)
File src/drivers/amd/agesa/oem_s3.c:
https://review.coreboot.org/c/coreboot/+/44294/comment/341e8ee5_b8c39152
PS5, Line 29: u32 s3_data = CONFIG_S3_DATA_POS;
Layout of the s3nv file changes. This could break some fam16kb with ENABLE_MRC_CACHE=y and UPDATE_IMAGE=y, if s3nv contains data generated with older commit. I think it's fine to ignore this here if we have MRC_CACHE_DATA that will break such compatibility anyways.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia58e7cd1afb785ba0c379ba75ef6090b56cb9dc6
Gerrit-Change-Number: 44294
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 18 May 2022 09:53:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment