Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41890 )
Change subject: dptf: Add support for Running Average Power Limits
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41890/10/src/acpi/acpigen_dptf.c
File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/41890/10/src/acpi/acpigen_dptf.c@39...
PS10, Line 390: pl1
should these all be pl2?
Whoops, copy-pasta strikes again.
https://review.coreboot.org/c/coreboot/+/41890/10/src/include/acpi/acpigen_d...
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/41890/10/src/include/acpi/acpigen_d...
PS10, Line 167: RAPLs
maybe define RAPL here
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67e80d661ea5bb79980ef285eca40c9a4b0f1849
Gerrit-Change-Number: 41890
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 02:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment