Attention is currently required from: Lance Zhao, Furquan Shaikh, Tim Wawrzynczak.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55027 )
Change subject: acpi/device: Add ability to generate proper _STA for PowerResource
......................................................................
Patch Set 2:
(1 comment)
File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/55027/comment/c21a8f56_7b7de97f
PS2, Line 459:
: /* Write a _STA method that checks the state of the GPIOs. Otherwise
: * the _STA method will always return _ON.
: */
: bool enable_status;
It looks the comment and name of bool need to explain a litter bit better for next person whom will […]
How about use_gpio_for_status?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91410556db002c620fd9aaa99981457808da93a5
Gerrit-Change-Number: 55027
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 01 Jun 2021 15:14:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Gerrit-MessageType: comment
