[coreboot-gerrit] Change in coreboot[master]: lib/romstage_save: Add methods to pass on romstage information

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36291 )

Change subject: lib/romstage_save: Add methods to pass on romstage information
......................................................................

Patch Set 13:

(1 comment)

As written, this is a single caller API and there's nothing preventing misuse. I'm not understanding the need.

https://review.coreboot.org/c/coreboot/+/36291/13/src/lib/romstage_save.c 
File src/lib/romstage_save.c:

https://review.coreboot.org/c/coreboot/+/36291/13/src/lib/romstage_save.c@47 
PS13, Line 47: 		cbmem_entry_remove(e);
This only works if CBMEM_ID_ROMSTAGE_SAVE is the last entry added. And it also doesn't work if the cbmem is locked (recovered from on resume or through other stages).