Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel, Julius Werner, mturney mturney. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support ......................................................................
Patch Set 28:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45206/comment/13d7969e_ad9bf5ce PS15, Line 8:
In addition to the description Paul is asking for can you please add: […]
1. Is this code copied? yes, we have copied from trogdor(sc7180) 2. What payload was used? depthcharge 3. What works? Could you please clarify the question.
File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/comment/7f0893d8_f9bbe13d PS15, Line 262: default n
I think that you should just merge https://review.coreboot.org/c/coreboot/+/47527 into this patch. […]
This changes has been addressed
File payloads/libpayload/configs/config.herobrine:
https://review.coreboot.org/c/coreboot/+/45206/comment/ae9b8048_68b0aa9a PS22, Line 5: CONFIG_LP_SC7280_SERIAL_CONSOLE
Can we just pull this change into this patch?
This changes has been addressed
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/comment/1cf9120b_c839b9f6 PS6, Line 40: default 0xa
I'm trying to get that info from Jim right now. […]
DRIVER_TPM_SPI_BUS and EC_GOOGLE_CHROMEEC_SPI_BUS as per legacy sc7180 chipset updated these values.it may not accurate