Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47259 )
Change subject: soc/intel/tigerlake: Update Kconfig for NEM Enhanced Mode ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47259/13/src/soc/intel/tigerlake/Kc... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47259/13/src/soc/intel/tigerlake/Kc... PS13, Line 26: USE_CAR_NEM_ENHANCED_V1
In the other CL, I selected INTEL_CAR_NEM for the boards using ESx. […]
So, basically there would be two CLs:
** First CL: ** soc/intel/tigerlake/Kconfig --> Use `select INTEL_CAR_NEM_ENHANCED_V2 if !INTEL_CAR_NEM` instead of `select INTEL_CAR_NEM` mainboard/google/volteer/Kconfig.name --> Drop `select INTEL_CAR_NEM_ENHANCED_V2` from the variants selecting it. --> Add `select INTEL_CAR_NEM` to all variants that were not selecting INTEL_CAR_NEM_ENHANCED_V2 before mainboard/intel/tglrvp/Kconfig --> Add `select INTEL_CAR_NEM` since it is not selecting INTEL_CAR_NEM_ENHANCED_V2
** Second CL: ** soc/intel/tigerlake/Kconfig --> Use `select INTEL_CAR_NEM_ENHANCED_V1 if !INTEL_CAR_NEM` instead of `select INTEL_CAR_NEM_ENHANCED_V2 if !INTEL_CAR_NEM` --> Add `select COS_MAPPED_TO_MSB if INTEL_CAR_NEM_ENHANCED` (For second CL you can add the information about why we are switching to V1 and how this will be fixed once SF mask configuration is figured out)