Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama ......................................................................
Patch Set 29:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34505/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/14//COMMIT_MSG@13 PS14, Line 13: https://crrev.com/c/1565758
Thank you for the URL, but it’s kind of “cheating” as that commit does not have any more information […]
Ack
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 28: .hborder = 0,
you can remove the 0 .hborder to prevent exceeding col 80.
Ack
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 29: .vborder = 0,
you can remove the 0 .vborder to prevent exceeding col 80.
Ack
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 332: BOE_TV101WUM_N53
so it's N53, not N16?
Ack
https://review.coreboot.org/c/coreboot/+/34505/15/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/15/src/mainboard/google/kukui... PS15, Line 332: BOE_TV101WUM_N53
I have confirmed with verndor and init code is same with NL6, just edid need follow N53 spec. […]
Ack