[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede/var/drawcia: Change power sequencing of Camera and VCM

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61147 )

Change subject: mb/google/dedede/var/drawcia: Change power sequencing of Camera and VCM
......................................................................

mb/google/dedede/var/drawcia: Change power sequencing of Camera and VCM

Drawcia's MIPI camera sensor and VCM both share the same reset GPIO
from the PCH. The current power sequence does not take this into
account, and this leads to an unbalanced ref count of the reset GPIO,
which can cause one or the other of the devices to reset unexpectedly.

This patch corrects that by explicitly sequencing the reset GPIO for
both devices, which the builtin refcounting of this driver will
automatically handle.

BUG=b:214665783
TEST=Build, boot to OS and check VCM once camera stream off

Signed-off-by: Varshit B Pandya 
Change-Id: Ib676fd1f43dbd9cf75e4aff01baab4a4bb4e2a89
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61147
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
1 file changed, 10 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
index cb3ff48..2b32e9b 100644
--- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
@@ -314,12 +314,13 @@
    			register "gpio_panel.gpio[2].gpio_num" = "GPP_D12" #reset

#_ON
-				register "on_seq.ops_cnt" = "5"
+				register "on_seq.ops_cnt" = "6"
    			register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)"
    			register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)"
    			register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)"
-				register "on_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(2, 5)"
-				register "on_seq.ops[4]" = "SEQ_OPS_GPIO_ENABLE(2, 5)"
+				register "on_seq.ops[3]" = "SEQ_OPS_GPIO_ENABLE(2, 5)"
+				register "on_seq.ops[4]" = "SEQ_OPS_GPIO_DISABLE(2, 5)"
+				register "on_seq.ops[5]" = "SEQ_OPS_GPIO_ENABLE(2, 0)"

#_OFF
    			register "off_seq.ops_cnt" = "4"
@@ -342,12 +343,16 @@
    			register "low_power_probe" = "1"

register "gpio_panel.gpio[0].gpio_num" = "GPP_D13" #power_enable_2p8
+				register "gpio_panel.gpio[1].gpio_num" = "GPP_D12" #reset
    			#_ON
-				register "on_seq.ops_cnt" = "1"
+				register "on_seq.ops_cnt" = "2"
    			register "on_seq.ops[0]" = "SEQ_OPS_GPIO_ENABLE(0, 0)"
+				register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(1, 5)"
    			#_OFF
-				register "off_seq.ops_cnt" = "1"
+				register "off_seq.ops_cnt" = "2"
    			register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"
+				register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(1, 5)"
+
    			device i2c 0C on end
    		end
    		chip drivers/intel/mipi_camera

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.