Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32117 )
Change subject: soc/intel/cannonlake: Configure Vmx support using Kconfig ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/32117/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32117/2//COMMIT_MSG@7 PS2, Line 7: soc/intel/cannonlake: Vmx support based on Kconfig
Please use a statement by adding a verb (in imperative mood): […]
done
https://review.coreboot.org/#/c/32117/2//COMMIT_MSG@10 PS2, Line 10: Devicetree
devicetree
done
https://review.coreboot.org/#/c/32117/2/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32117/2/src/soc/intel/cannonlake/romstage/fs... PS2, Line 64: /* Disable Vmx if Vt-d is already disabled */
VT-d is a separate feature from Vmx. […]
Patch set 4 I removed Vmx dependency on VTD.
https://review.coreboot.org/#/c/32117/3/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32117/3/src/soc/intel/cannonlake/romstage/fs... PS3, Line 64: /* Change VmxEnable UPD value accoding to ENABLE_VMX Kconfig */
'accoding' may be misspelled - perhaps 'according'?
done