David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35320 )
Change subject: soc/fsp_broadwell_de: Move function to get CPUBUSNO(1) into common file
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35320/3/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/35320/3/src/soc/intel/fsp_broadwell...
PS3, Line 71: busno1
maybe just call get_busno1() here if there's no need for error checking? That will reduce this code by a couple of lines.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35320
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I189eb8ffce2f0735ad9ba603b1d96786aa00fafb
Gerrit-Change-Number: 35320
Gerrit-PatchSet: 3
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Sep 2019 18:54:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment