Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 )
Change subject: soc/intel/tigerlake: Update Kconfig
......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco...
PS8, Line 84: 0x30000
This CL conflicts with https://review.coreboot.org/c/coreboot/+/37764/. […]
+1 to Furquan's comments.
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco...
PS8, Line 147: 7
Is this really correct?
As per JSL EDS only 3 SPI ports
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco...
PS8, Line 151: 8
I see only 6 in EDS.
As per JSL EDS only 6 I2C ports
https://review.coreboot.org/c/coreboot/+/37426/8/src/soc/intel/tigerlake/Kco...
PS8, Line 155: default 7
As per JSL EDS only 3 UART ports
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c
Gerrit-Change-Number: 37426
Gerrit-PatchSet: 8
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 18 Dec 2019 18:04:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment