Matt Parnell has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34888 )
Change subject: util/superiotool: add IT8987 detection and register support ......................................................................
Patch Set 6:
(1 comment)
Patch Set 5:
(5 comments)
I believe patch set 7 has addressed all concerns mentioned so far; I removed the LDN specific definitions.
https://review.coreboot.org/c/coreboot/+/34888/5/util/superiotool/ite.c File util/superiotool/ite.c:
https://review.coreboot.org/c/coreboot/+/34888/5/util/superiotool/ite.c@1092 PS5, Line 1092: {NOLDN, "Logical Device Activate Register (LDA)", : {0x30,EOT}, : {0x00,EOT}}, : {NOLDN, "I/O Port Base Address for Descriptor 0 (IOBAD0)", : {0x60,0x61,EOT}, : {NANA,NANA,EOT}}, : {NOLDN, "I/O Port Base Address for Descriptor 1 (IOBAD1)", : {0x62,0x63,EOT}, : {NANA,NANA,EOT}}, : {NOLDN, "Interrupt Request Number and Wake-Up on IRQ Enable (IRQNUMX)", : {0x70,EOT}, : {NANA,EOT}}, : {NOLDN, "Interrupt Request Type Select (IRQTP)", : {0x71,EOT}, : {NANA,EOT}}, : {NOLDN, "DMA Channel Select 0 (DMAS0)", : {0x74,EOT}, : {0x04,EOT}}, : {NOLDN, "DMA Channel Select 1 (DMAS1)", : {0x75,EOT}, : {0x04,EOT}},
For context: These are specified in the datasheet as the common fields of the LDN-specific registers […]
Which explains why other models usually leave these out...I'll fix and push shortly.