Attention is currently required from: Julius Werner.
jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48557 )
Change subject: tests: Add lib/fmap-test test case
......................................................................
Patch Set 6:
(2 comments)
File tests/lib/fmap-test.c:
https://review.coreboot.org/c/coreboot/+/48557/comment/0cccca82_7d8cc84f
PS4, Line 94: mem_rdev_fmap_ro.rdev.root = &mem_rdev_ro.rdev;
Done
Sure, You are right. This code is not necessary. This is leftover after I refactored boot_device_ro/rw from my implementation to mem_region_device.
https://review.coreboot.org/c/coreboot/+/48557/comment/e91ff098_745253cd
PS4, Line 204: ar.offset = 2142037;
Done
Good idea. I added more cases testing areas outside flash region, overlapping with other sections or with incorrect offset or size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48557
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I885ea05d509d3b1330de7a18531f310d290c6965
Gerrit-Change-Number: 48557
Gerrit-PatchSet: 6
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 07 Jan 2021 13:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jacz@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment