Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47151 )
Change subject: drivers/intel/gma: Add Kconfig option for vbt data size
......................................................................
Patch Set 3:
Patch Set 2:
(3 comments)
I wonder why we don't use the heap (malloc()) instead. We wouldn't
need additional (Kconfig) knowledge that way.
That would work. If we do that, we should probably bump up the heap sizes for all the platforms using this driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47151
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia294fc94ce759666fb664dfdb910ecd403e6a2e9
Gerrit-Change-Number: 47151
Gerrit-PatchSet: 3
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 04 Nov 2020 18:50:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment