Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver ......................................................................
Patch Set 27:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45398/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45398/7//COMMIT_MSG@11 PS7, Line 11:
Where is the interface documented? Please add a datasheet name and revision.
Ack
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/Ma... File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/Ma... PS14, Line 12: bootblock
I think there are several modules, like rtc/clkbuf/srclken_rc, which depend on pmif module. […]
Ack. rtc_init is done in bootblock.
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi... File src/soc/mediatek/mt8192/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi... PS7, Line 200: write32(&arb->mtk_pmif->inf_cmd_per_1, cmd_per);
inf_cmd_per_1 is for the permission of interface 8~15 and inf_cmd_per_0 is for the permission of int […]
Ack