cedarhouse1@comcast.net has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 37:
Patch Set 37:
Patch Set 36:
Patch Set 33:
(13 comments)
To do: I am looking for guidance/direction about the config to get Jenkins to build the STM.
Next patch set will be out Fri/Sat and will include the addition of get_pmbase for all Intel platforms. Unless the reviewers want me to separate them into separate CL's
Given the requests people made to have it in one CL, back when it was multiple CLs, let's just keep it in one CL.
given the comments I've received in keeping the CL as one large entity, I can easily split out the just added modifications, into a separate CL without harm (aside from certain platforms not building when the STM because of a linking error).
However, I have a more fundamental issue. I have added a "select USE_BLOBS" to stm/Kconfig to ensure that 3rdparty/blobs/cpu/intel/stm/* is pulled in as it is needed to build.
The blobs directory is pulled but the cpu/intel/stm directory is not pulled in, which is causing the Jenkins regression builds to abort.
If I go to review.coreboot.org/blobs the STM directory is there in master and is in the commit log.
When go to 3rdparty/blobs on my test system, as noted earlier, the cpu/intel/stm directory is not there.
When I do a "git status" I receive the following message:
HEAD detached at 034b278 nothing to commit, working directory clean
A "git log" produces a list of commits starting after the cpu/intel commit.
How do we fix this as this is what is prevent a clean build with the STM enabled.
gene
Please do not review this patch set, I need to resolve this first (just that this system is not allowing me to send a message otherwise)