Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52859 )
Change subject: mb/google/brya: enable DPTF functionality for brya
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52859/comment/3689eaef_3f58cb5c
PS3, Line 14: Ambient
I only see the first two sensors in the EC code... […]
I added these sensors based on Schematics. Yes, even I am seeing this on my system. I am checking with hardware team, is this sensor physically available or not on board, that might be one of the reason it's showing negative temp value. Thanks for finding this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33266c85aa30869466034ccbab04a3c7820ae2b0
Gerrit-Change-Number: 52859
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 12 May 2021 03:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment
